feat: limit broadcast payload size #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgurgel
reviewed
Oct 23, 2025
filipecabaco
force-pushed
the
feat/broadcast-payload-size
branch
from
d7faa75 to
219e6cc
Compare
edgurgel
reviewed
Oct 27, 2025
Comment on lines
387
to
389
| Process.sleep(120) | ||
|
|
||
| refute_received {:socket_push, :text, _} |
There was a problem hiding this comment.
Suggested change
| Process.sleep(120) | |
| refute_received {:socket_push, :text, _} | |
| refute_receive {:socket_push, :text, _}, 120 |
Comment on lines
368
to
370
| Process.sleep(120) | ||
|
|
||
| refute_received {:socket_push, :text, _} |
There was a problem hiding this comment.
Suggested change
| Process.sleep(120) | |
| refute_received {:socket_push, :text, _} | |
| refute_receive {:socket_push, :text, _}, 120 |
Comment on lines
345
to
347
| Process.sleep(120) | ||
|
|
||
| refute_received {:socket_push, :text, _} |
There was a problem hiding this comment.
Suggested change
| Process.sleep(120) | |
| refute_received {:socket_push, :text, _} | |
| refute_receive {:socket_push, :text, _}, 120 |
Comment on lines
330
to
332
| Process.sleep(120) | ||
|
|
||
| refute_received {:socket_push, :text, _} |
There was a problem hiding this comment.
Suggested change
| Process.sleep(120) | |
| refute_received {:socket_push, :text, _} | |
| refute_receive {:socket_push, :text, _}, 120 |
| messages: list(%{id: String.t(), topic: String.t(), payload: map(), event: String.t(), private: boolean()}) | ||
| }, | ||
| super_user :: boolean() | ||
| ) :: :ok | {:error, atom()} |
There was a problem hiding this comment.
So does it return :ok | {:error, atom() | changeset ? Should it be {:error, changeset} to be consistent?
|
|
||
| @doc """ | ||
| """ | ||
| @spec validate_payload_size(Tenant.t() | binary(), map()) :: :ok | {:error, :payload_size_exceeded} |
There was a problem hiding this comment.
Should we update PresenceHandler to also use this function?
edgurgel
approved these changes
Oct 27, 2025
Limits broadcasting messages with payloads bigger than what the tenant as set as the limit
filipecabaco
force-pushed
the
feat/broadcast-payload-size
branch
2 times, most recently
from
ffe3480 to
aec1438
Compare
filipecabaco
force-pushed
the
feat/broadcast-payload-size
branch
from
aec1438 to
8f4c4c7
Compare
|
🎉 This PR is included in version 2.57.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
edgurgel
reviewed
Oct 27, 2025
| {:noreply, state} | ||
| else | ||
| {:error, %Ecto.Changeset{valid?: false} = changeset} -> | ||
| error = Ecto.Changeset.traverse_errors(changeset, &elem(&1, 0)) |
edgurgel
reviewed
Oct 27, 2025
| end | ||
|
|
||
| def call(conn, %Ecto.Changeset{valid?: true} = changeset) do | ||
| def call(conn, {:error, %Ecto.Changeset{valid?: false} = changeset}) do |
There was a problem hiding this comment.
Compiling 10 files (.ex)
warning: this clause cannot match because a previous clause at line 32 always matches
│
48 │ def call(conn, {:error, %Ecto.Changeset{valid?: false} = changeset}) do
│ ~
│
└─ lib/realtime_web/controllers/fallback_controller.ex:48:7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Limits broadcasting messages with payloads bigger than what the tenant as set as the limit